search

tobybatch / kimai2

Docker containers for the kimai2 web application including docker-compose and kubernetes/helm deployment.
MIT License
183 stars 97 forks source link

Fix "KIMAI" arg, vulnerabilities and more #477

Closed hexxone closed 1 year ago

hexxone commented 1 year ago

Hi there, I'm following up to #476 .

I took some time to fix the main issue, by passing through the "KIMAI" arg in the correct places in Dockerfile. While I was at it, I did the same for "TIMEZONE" (previously "TZ").

Then I noticed there are some vulnerabilities included due to an outdated PHP Version being used (8.1.12 & 8.1.13). image

So I took the liberty to fix it by introducing two new arguments "PHP_VER" and "COMPOSER_VER" and now using PHP 8.1 (implicitly 8.1.16) and composer "latest".

Afterwards I was able to confirm that the "KIMAI" env var now gets set correctly and the PHP vulnerabilities are gone. image

Everything seems to work accordingly for now.

Also refactored the Markdown files according to lint rules and added a "Manual build" Section in Contributing, incorporating the new Args.

Let me know what you think :) Cheers

hexxone commented 1 year ago

Alright, no problem and sorry

Just give me some minutes :)

kevinpapst commented 1 year ago

Really no reason to be sorry, your input is very much appreciated 👍

I am just trying to make the review and merge process as smooth as possible. Thanks for re-doing the PR!

hexxone commented 1 year ago

Ok, I hope its alright now :)

Let me know if theres something else.