search

tobychui / SlicerA

A web based STL to Gcode slicer for ArozOS
Apache License 2.0
24 stars 4 forks source link

Some small fixes #1

Closed aligator closed 3 years ago

aligator commented 3 years ago

Hi

I needed some small fixes to get it working on my machine:

  1. The Goslice binaries need chmod +x permission to be executable on linux
  2. Somehow my browser (firefox) sent a different base64 header with the stl file. I just split it now at , then it should work with every mimetype header.
  3. -port 8080 doesn't work, it has to be :8080 -> corrected that in the readme.

Then it works flawlessly :+1:
Thanks for your work!

tobychui commented 3 years ago

As I am using Windows as my main dev machine, I guess the permission will get messed up again after I pull & push any updates. Maybe I will just add the permission setup instruction to the README so people know what to do when they build it. Thank you for your review and PR!

aligator commented 3 years ago

Yes, maybe we should replace the need for the binaries somehow. Wouldn't it be a better way to just call GoSlice as lib directly? Then we wouldn't need extra binaries. As SlicerA is also AGPL it shouldn't be any problem as you have to provide it anyway as extra module to ArozOS.