search

tobychui / arozos

Web Desktop Operating System for low power platforms, Now written in Go!
https://os.aroz.org
GNU General Public License v3.0
2k stars 145 forks source link

[Feature request] Shareable link to files #28

Closed jivank closed 3 years ago

jivank commented 3 years ago

Describe the solution you'd like When right clicking a file, an option to share the file will be available. It will create a link that goes to a landing page which allows guests to download the file.

tobychui commented 3 years ago

This was on our to-do list a few months ago and we are working on that right now, what a coincidence :))

2020-12-06_13-21-27

jivank commented 3 years ago

It looks good!

tobychui commented 3 years ago

Function added in arozos 1.107 updates (Already included in the current source code) Binary will be released around next week.

The share interface will looks like this : ) 2020-12-13_12-20-38

jivank commented 3 years ago

I have a pullrequest that I put together very quickly that will allow for custom preview images for any file. Would like to discuss how you envision implementing it.

Also would like to report that the UUIDs still exist after renaming the file (also possibly when deleting a file). Perhaps a simple fix would be to purge non-existent shares on startup.

tobychui commented 3 years ago

I have a pullrequest that I put together very quickly that will allow for custom preview images for any file. Would like to discuss how you envision implementing it.

Also would like to report that the UUIDs still exist after renaming the file (also possibly when deleting a file). Perhaps a simple fix would be to purge non-existent shares on startup.

I am working on a new ArozOS module that allow internal function to run once each night. I guess I will be adding the purge logic there. Can you share the link to your implementation to me for reference? Thanks!

tobychui commented 3 years ago

Invalid share UUID cleaning mechanism has been scheduled to be implement in v1.109 release