tobychui / arozos

Web Desktop Operating System for low power platforms, Now written in Go!
https://os.aroz.org
GNU General Public License v3.0
2k stars 145 forks source link

[BUG] Custom User with custom group can't show system info ... #89

Closed fred2088 closed 2 years ago

fred2088 commented 2 years ago

Describe the bug a new user "test" with a new group "Test" can't display info while admin can show details

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Host Information(please complete the following information):

Client Information(please complete the following information):

Additional context Add any other context about the problem here.

fred2088 commented 2 years ago

Another issue is when group qota is changed from 100KB to 100MB, the user quota limit is still 100KB ?

fred2088 commented 2 years ago

for normal user, is it to hide "Disk Space" like other TAB ? instead of showing Permssion Denied when clicking the TAB ?

image

tobychui commented 2 years ago

It seems you have invalid group permission setting regarding the new user group. Are you sure you have allowed the new user group to access "System Setting" module? Can you screenshot the user group permission setting for us? Thanks!

fred2088 commented 2 years ago

all are default settings with only define 100KB first hand and then changed to 100MB image

tobychui commented 2 years ago

all are default settings with only define 100KB first hand and then changed to 100MB image

It seems you have a wrong "Allow Access" permission setting. In normal cases where you want to create a permission group for human users, you have to put at least "File Manager", "System Settings" and "Trash Bin" into the allow access module list. A permission group with "Allow Access" permission empty is usually for bots or a customize interface module (e.g. billboard).

Here is an example setting for a "design for human" user group: 圖片

fred2088 commented 2 years ago

Ha Ha, only GOD knows ...

fred2088 commented 2 years ago

Another issue is when group qota is changed from 100KB to 100MB, the user quota limit is still 100KB ?

How about this ?

fred2088 commented 2 years ago

all are default settings with only define 100KB first hand and then changed to 100MB image

It seems you have a wrong "Allow Access" permission setting. In normal cases where you want to create a permission group for human users, you have to put at least "File Manager", "System Settings" and "Trash Bin" into the allow access module list. A permission group with "Allow Access" permission empty is usually for bots or a customize interface module (e.g. billboard).

Here is an example setting for a "design for human" user group: 圖片

It's a bit incorrect to allow use the "system settings" without permission !

tobychui commented 2 years ago

Another issue is when group qota is changed from 100KB to 100MB, the user quota limit is still 100KB ?

How about this ?

This is working by design. When you change the group quota, it only applies to any new users added to the group. It is necessary to implement this way due to the complexity of a multi-user multi-permission group system.

It's a bit incorrect to allow use the "system settings" without permission !

This is also normal. If a user do not have access to system settings module, the user can only load the template of the system setting but not any function or API call from it (That is why when you try to open it with a user that has no access permission to the system setting / info tab, it shows all undefined and not usable).

The issue is the invalid configuration of auto created shortcut on desktop where you can customize what to create on user creation by changing the content in the system/desktop/template/ folder.

fred2088 commented 2 years ago

Totally agree if it's self explained when creating group or have a option as default settings ...