[BUG] Failed to construct 'WebSocket': The Url conains a fragment identifier

tobychui / arozos

Web Desktop Operating System for low power platforms, Now written in Go!

http://arozos.com

GNU General Public License v3.0

1.87k stars 138 forks source link

[BUG] Failed to construct 'WebSocket': The Url conains a fragment identifier #91

Closed twinklestar03 closed 2 years ago

twinklestar03 commented 2 years ago

Describe the bug The upload will fail when upload a folder or a file which the filename contain '#' character.

Expected behavior Should be able to upload things with # in filename.

Host Information(please complete the following information):

OS: Ubuntu 20.04
Go version: go version go1.16.7 linux/amd64
Arozos version: ArozOS development Revision 0.1.120

yeungalan commented 2 years ago

Hi, may I know what browser you are using?

tobychui commented 2 years ago

Hi @twinklestar03 ,

Thanks for raising this issue. This was caused by a missing encodeURIComponent in the upload endpoint generator. The bug has been fixed and will be pushed with the latest update in v1.121.

Thanks so much for your contribution! (Issue will be closed after v1.121 release)

twinklestar03 commented 2 years ago

Thanks for the fast patch. 🥳

tobychui commented 2 years ago

Patch has been released with v1.121

twinklestar03 commented 2 years ago

Sorry I have to re-open this issue, I think the patch is kinda broken. After apply the latest version, whenever upload a filename contain a Chinese or Japanese characters, the filename won't be urldecoded.

tobychui commented 2 years ago

Hi @twinklestar03,

I have try to apply a fix on commit #a42c4e2f4e3fbc675387299d620d673261bd1d78. You mind having a try on the latest source code and see if the problem still exists? Thanks!

twinklestar03 commented 2 years ago

I've apply the patch, now things work just fine.