search

tobydeh / nativescript-download-progress

Download large files in Nativescript with progress events
Apache License 2.0
11 stars 16 forks source link

Feat: update for NS7 #20

Closed bradmartin closed 3 years ago

bradmartin commented 3 years ago

Implements NS7 support for the plugin source.

bradmartin commented 3 years ago

nativescript-download-progress-2.0.0.tgz.zip

Zip containing a tgz for this PR for those who need NS7 support before merge and publish.

tobydeh commented 3 years ago

Hi thank you for this - much appreciated. Could you please remove the prettier config and use the existing eslint config for formatting and ill merge it in? If you don't have time I'll tackle it asap.

Thanks again.

bradmartin commented 3 years ago

I'll try to get back to that in a bit, didn't mean to push it up. Was trying to keep it consistent and my setup just overrides eslint configs 🙃 so I added that for my dev to avoid some silly file changes, but yep I'll get it cleaned up in a bit.

bradmartin commented 3 years ago

@tobydeh - apologies but I'm not sure how to use eslint config for formatting, not with VSCode anyway. When formatting it's using double quotes which is not what the source originally had so it's not being applied or maybe some rules locally are overwriting the config.

If you have a command or flow to follow I'd be glad to do it though.

bradmartin commented 3 years ago

Also just pushed a small change that I noticed where I wasn't added the correct weakref to the iOS delegate, should work now 👍

tobydeh commented 3 years ago

No problem - I'll sort it and publish a new version.

On Thu, 24 Sep 2020 at 19:21, Brad Martin notifications@github.com wrote:

@tobydeh https://github.com/tobydeh - apologies but I'm not sure how to use eslint config for formatting, not with VSCode anyway. When formatting it's using double quotes which is not what the source originally had so it's not being applied or maybe some rules locally are overwriting the config.

If you have a command or flow to follow I'd be glad to do it though.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tobydeh/nativescript-download-progress/pull/20#issuecomment-698508922, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUGIFPF5GEO6GILVTTEX3SHOE3FANCNFSM4RYKKYAA .

bradmartin commented 3 years ago

Be sure the ts-patch install runs before publishing, not sure what flow you follow but if it doesn't the @NativeClass() decorator on the delegate will end up outputting ES2017 for the extends class there and not ES5 which is what the runtimes need for native classes that are extended.

tobydeh commented 3 years ago

1.4.0 published

bradmartin commented 3 years ago

Probably should have bumped a major with this one @tobydeh since it's a breaking change for NS and won't work with users on NS6 who have ^1.3.0 in their dependencies.