search

tobydeh / nativescript-download-progress

Download large files in Nativescript with progress events
Apache License 2.0
11 stars 16 forks source link

Plugin package.json missing keys to be considered a NS plugin... #26

Closed NathanaelA closed 2 years ago

NathanaelA commented 3 years ago

Please, tell us how to recreate the issue in as much detail as possible.

The package json file should have a "nativescript" -> "platforms" key for it to be picked up as an real NativeScript plugin, right now it is treating it as a normal JS npm module. Fortunately you do not appear to be using any native code or resources, but if you were the NS CLI, wouldn't pick any of it up without it being tagged as an actual NativeScript plugin. This also keeps it from showing up on sites like https://plugins.nativescript.rocks because it looks for that key to determine if it is a NativeScript plugin.

"nativescript": {
  "platforms": {
    "android": "1.0.0",
    "ios": "1.0.0"
  }
}

See https://plugins.nativescript.rocks/create for more info...