tobydeh / nativescript-download-progress

Download large files in Nativescript with progress events
Apache License 2.0
11 stars 16 forks source link

fix worker bug when downloading multiple files successively. #4

Closed dali-gharbi closed 6 years ago

dali-gharbi commented 6 years ago

Hi @flipcode , we encountered issues when trying to download multiple files successively. this was the solution for us we did the require inside the download function. ps: this solution worked for both builds using and without using webpack.

Which platform(s) does your issue occur on?

Please, provide the following version numbers that your issue occurs with:

tobydeh commented 6 years ago

Hi can you test that this patch works on iOS devices as well and I'll merge it in. Thanks for the assistance.

7ammer commented 6 years ago

BTW this is also an issue on IOS devices as well. Start first download, then start second download. One will not complete its Promise if the other has already finished downloading.

dali-gharbi commented 6 years ago

hi @tobydeh i will test it on ios and please note that my pull request include changes only in the .android file doest that really affect the plugin on ios ?

tobydeh commented 6 years ago

Sorry, what I meant was can you confirm downloading multiple files on iOS causes the same error and if so fix both in the same pull request.

I’m not using workers on iOS so it shouldn’t do.

Can you provide me with the code your using to download multiple files and I’ll look into it myself?

Thank you.