search

tobydragon / metafora-project

Automatically exported from code.google.com/p/metafora-project
1 stars 0 forks source link

return key should commit text #167

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
when typing in a lasad box, when the user presses enter, it should commit the 
text and lose focus (remove the lock) on that box.

Original issue reported on code.google.com by tdragon1...@gmail.com on 13 Sep 2012 at 5:21

GoogleCodeExporter commented 9 years ago

Original comment by tdragon1...@gmail.com on 10 Oct 2012 at 11:11

GoogleCodeExporter commented 9 years ago 
'ENTER' button press is implemented

Original comment by almer.bo...@gmail.com on 17 Oct 2012 at 12:55

GoogleCodeExporter commented 9 years ago 
Two things:  

1) There is a bug...  when the person hits enter, the "focus" leaves and the 
text is committed, but if the person keeps typing, it still changes the text 
even though the author no longer has ownership of the box (bug pointed out by 
Clausthal).

2) This should be another template option (EnterKeyCommitsText = true).  
Default should have the old behavior so we are not changing LASAD unless people 
want the change.

Original comment by tdragon1...@gmail.com on 18 Oct 2012 at 10:11

GoogleCodeExporter commented 9 years ago 
In order to undo changes made regarding this issue, one can comment lines 
145-152 in file lasad.gwt.client.ui.common.elements.ExtendedTextElement.java

Original comment by almer.bo...@gmail.com on 22 Oct 2012 at 11:08

GoogleCodeExporter commented 9 years ago 
bug reported about the commit not removing the cursor only happens in Internet 
Explorer, please look into this...

Original comment by tdragon1...@gmail.com on 2 Nov 2012 at 8:39

GoogleCodeExporter commented 9 years ago 
Commit by enter can be switched on/off by setting 'committextbyenter' attribute 
in template file. Pressing ENTER, SHIFT+ENTER was tested in Firefox.

Original comment by almer.bo...@gmail.com on 7 Nov 2012 at 11:12

GoogleCodeExporter commented 9 years ago

Original comment by almer.bo...@gmail.com on 28 Nov 2012 at 12:16

GoogleCodeExporter commented 9 years ago 
Also tested in chrome

Original comment by tdragon1...@gmail.com on 31 Jan 2013 at 10:38