search

tobyink / p5-json-schema

1 stars 4 forks source link

Remove detect() method and drop HTTP::Link::Parser dependency? #1

Open matthof opened 10 years ago

matthof commented 10 years ago

Hey - thanks for putting together JSON::Schema, it is super useful.

I noticed that the dependency tree for JSON::Schema is much smaller if HTTP::Link::Parser is pulled out; and that HTTP::Link::Parser is only needed for the detect() method, which isn't strictly necessary for schema parsing... it is only used to pull in remote schemas. This feature isn't important for my use case, and I would bet that many users wouldn't need this feature either.

As such, I was wondering if it would make sense to decouple JSON::Schema (just the schema parsing parts) from detect() and HTTP::Link::Parser. This would make the module easier to import, without having to pull in a ton of other modules.

I would push this change myself, but it feels weird submitting a change that deletes functionality w/o consulting the maintainer... what are your thoughts?

tobyink commented 10 years ago

I've got a bunch of changes for JSON::Schema loosely planned. Reducing the dependency chain is on the list.

In the case of HTTP::Link::Parser, my plan was to keep JSON::Schema depending on it, but reduce the dependency chain of HTTP::Link::Parser itself. I've released HTTP::Link::Parser 0.200 tonight, which should be much more lightweight.

Do you consider that sufficient to close this issue?