tobymao / 18xx

A platform for playing 18xx games online!
https://18xx.games
Other
297 stars 186 forks source link

[1822CA] P10 can not be used late game to add a station to Winnipeg #10173

Closed ScottDrone closed 9 months ago

ScottDrone commented 9 months ago

[1822CA] In Phase 7, Winnipeg already has 7 token slots displayed visually. 5 are occupied; 1 is reserved for GTP home station, and the last is unoccupied. GTR attempts to use P10 to place a free token in Winnipeg, but clicking on every part of the tile results in nothing, not even an error message.

Hotseat, Firefox

https://gist.github.com/ScottDrone/023561a13485e1adefee5e3ed0dad85c

JEBrosius commented 9 months ago

Here's another game:

https://18xx.games/game/148162?action=1201

In this game, I was able to place a late-game P10 station in Winnipeg with PGE. Note also that this game has one space too many where the GNW destination is (a bug that was previously reported.)

benjaminxscott commented 9 months ago

Looks like we need another test game

In the first game: https://gist.github.com/ScottDrone/023561a13485e1adefee5e3ed0dad85c

An error is thrown: "undefined method `round' for nil"

which could be the same issue as: https://github.com/tobymao/18xx/issues/10139

In the second game: https://18xx.games/game/148162 It's pinned so it's not possible to use as a test game (its code is disjoint from current codebase)

michaeljb commented 9 months ago

In theory I think Winnipeg could have 9 tokens: the 6 token slots, plus the 2 destination tokens, plus the P10 token. The rendering code currently only handles up to 7