[the old prince 1871] Cannot cross buy trains from other players with UB as president

[mr0santan]

164822 https://gist.github.com/benjaminxscott/9715803e7e2e58f4c00e687b943334e8

UB is president of a company and must buy a train. There is a button to show trains from other players but when I click it nothing happens.

126.0.6478.127 (Official Build) (64-bit) (cohort: Stable) a435861f0ca363a64f7485619ee5939833823fce-refs/branch-heads/6478@{#1592}

[benjaminxscott]

I suspect the buy_train view is getting into an infinite loop somewhere, since after clicking 'Show Other' and changing tabs the frontend freezes until reloading

To be precise, is your usecase to buy a train across from the MR?

In addition to the above UI issue, We should probably show trains owned by other corps who are owned by the owner of UB by default rather than hiding them under 'Other'

It looks like that logic is handled here, I tried to override real_owner() in the game-specific code but that didn't work as expected, it looks like UB is technically a Player so it may be more complex than that https://github.com/tobymao/18xx/blob/d13ca31ae7e4831643a911f3744f8d02b8ce88e4/assets/app/view/game/buy_trains.rb#L511

[mr0santan]

Yes I would like to buy the 2+ over for a dollar.

On Tue, Jul 2, 2024, 1:04 PM Benjamin Scott @.***> wrote:

I suspect the buy_train view is getting into an infinite loop somewhere, since after clicking 'Show Other' and changing tabs the frontend freezes until reloading

To be precise, is your usecase to buy a train across from the MR?

We should probably show other corps owned by the owner of UB by default rather than hiding them under 'Other'

It looks like that logic is handled here, I tried to override real_owner() in the game-specific code but that didn't work as expected, it looks like UB is technically a Player so it may be more complex than that

https://github.com/tobymao/18xx/blob/d13ca31ae7e4831643a911f3744f8d02b8ce88e4/assets/app/view/game/buy_trains.rb#L511

— Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/10997#issuecomment-2203856618, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJSPEKCHH4KCD4EU5ZLAD5LZKLMTPAVCNFSM6AAAAABKGLJK3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBTHA2TMNRRHA . You are receiving this because you authored the thread.Message ID: @.***>

[philcampeau]

This is similar to #8300 , but the fact that this issue is happening now tells me that 8300 has probably been resolved at some point without being closed.