tobymao / 18xx

A platform for playing 18xx games online!
https://18xx.games
Other
279 stars 182 forks source link

Shikoku 1889 - add corporations icon to the starting locations on the map #11022

Open konradh-cmyk opened 2 months ago

konradh-cmyk commented 2 months ago

Hello, sorry if this was already rised, couldn't find similar ticket.

I know there is marking done by letters like "IR" or "UR", but I think it would greatly improve experience of new players if the corporation logos were included on the map. Since game is already using the icons in other parts of the interface, maybe this shouldnt be a problem?

Best

philcampeau commented 2 months ago

As described, I don't know that this will be implemented.

That said, we could probably write some code that could display a faded gray-scale version of the logos on the home city spaces, sort of like how destination stations are shown on the physical map for 1846.

If we do that, I think it would also be nice to add some code that would also display the home stations on laid tiles, since there's no reason we can't display that info.

arseniybanayev commented 1 month ago

New user of site here - and also an engineer with long experience so would be very happy to help contribute to this great repo!

Agree with OP. The colored company icons are used in the Market so they should also be used in the Map. Why is it a different iconography?

philcampeau commented 1 month ago

New user of site here - and also an engineer with long experience so would be very happy to help contribute to this great repo!

Agree with OP. The colored company icons are used in the Market so they should also be used in the Map. Why is it a different iconography?

If we used the colored icon, would you differentiate between a tokened city and a reserve spot?

arseniybanayev commented 1 month ago

Good point. It would have to be a differentiation in value (or shading or something like you recommended). Happy to take a stab at your suggestion and get familiar with contribution guidelines, if that's okay!

philcampeau commented 1 month ago

Be my guest! I wasn't interested in taking on this task, just wanted to offer thoughts :)