search

tobymao / 18xx

A platform for playing 18xx games online!
https://18xx.games
Other
279 stars 182 forks source link

[18 India] Can't lay home token on OO hexes #11058

Closed bennettn404 closed 1 month ago

bennettn404 commented 1 month ago

https://18xx.games/game/171575?action=215

When EBR first operates, it lays its home OO tile on P17. Once the tile is laid, a prompt to select the home city from the 2 OO options comes up. When attempting to click on either city, the page gives an error and force refreshes and rolls back the action. Both myself and the owner in master mode had the same behavior.

126.0.6478.128 (Official Build) (64-bit)

JaySixA commented 1 month ago

The same problem in game 171572 with the EIR (same starting hex as EBR).

philcampeau commented 1 month ago

Looks like this affects all corps starting on OO hexes. Presumably any starting on hexes with more than one individual city.

I did a quick test, this doesn't happen in hotseat mode, so @EdPovi, make sure you're testing on a real game.

waaayback commented 1 month ago

Thanks for fixing this quickly. Can we get this pushed to the website? I think this is holding up every game of 18 India LOL

philcampeau commented 1 month ago

It's not fixed, I was just identifying where the problem seems to be.

ZakisanGithub commented 1 month ago

Looks like this affects all corps starting on OO hexes. Presumably any starting on hexes with more than one individual city.

In our game, did not come up for OO/Mumbai cities where only one Company was located, but it did occur when two companies in the placed OO tile were in the game.

https://18xx.games/game/171615

charliewilsonstaindrop commented 1 month ago

For completeness (?) we have the same issue in game #171527 where both SPD and NWR are railway companies in the game.

Adac27 commented 1 month ago

It make it a bit easier to reproduce: Of the 2 OO hexes, in our game (#171481), Delhi had only 1 company starting on it, but Kolkata had 2. The company starting on Delhi was able to place fine. It was only when a company starting in Kolkata tried to place did we run into this bug.

MatthewDeKoning commented 1 month ago

Bug caught in the act in game 171671 Cloning the game works fine. master mode / normal moves in the live game fail when choosing home station.

waaayback commented 1 month ago

Will the 18 India bugs be assigned soon (especially this one)? The game isn't really playable yet.

EdPovi commented 1 month ago

I have a fix going up soon (tm)

waaayback commented 1 month ago

cool,thanks!

fanman80 commented 1 month ago

I'm in https://18xx.games/game/171946 which is just starting SR 2, both Dehli companies (NWR and SPD) are not only in play but also ran in OR 1.1 & 1.2. Dehli now has a brown tile.