[ 1822] bidding on minor is able to break the bank

[ramanraj2]

repro, action immediately before minor receives capital at end of round https://18xx.games/game/48737?action=984

https://gist.github.com/benjaminxscott/684ba9c1cfbdc192a88e9fb08a2c5f47

In 1822+ noticed a couple of things. If bank is low and someone puts lots of cash on a minor, it reports as bank broken when the company is credited with cash over the par price. I guess the bug is not adding the bid to the bank first before paying the company. I have seen this a couple of times. No game detail, however, as I did not report at that time.

Second, in a game being played now, LNWR alone did not get appear to float even though sold out. In group chat, it was determined the behavior at the top of a column is to go down and to the right (keep same share price). In the end result, since the market shows the marker with space for floating, it was confusing to not see a message about the float. Some message about moving down and to the right for those cases would be helpful.

Game id for second issue: https://18xx.games/game/48310 Moment in game: 1822: Phase 7 - Operating Round 9.1 (of 2) - Lay/Upgrade Track, after stock round 9.

some dialog printout:

  [11:44]Threepumpchump passes
  [11:44]ramanraj passes
  [11:58]edhew passes
  [11:58]No bids on minor M20, it will close and a 7 train is removed
  [11:58]20 closes
  [11:58]SWR's share price changes from £330 to £360
  [11:58]NER's share price changes from £245 to £270
  [11:58]NBR's share price changes from £110 to £120
  [11:58]-- Programmed action removed due to round change
  [11:58]-- New player order: Threepumpchump (£2298), ramanraj (£1136), edhew (£367)
  [11:58]-- Operating Round 9.1 (of 2) --
  [11:58]SWR collects £10 from P11-B&ER
  [11:58]Threepumpchump operates SWR
  [11:58]SWR skips acquire private companies
  [12:30]ramanraj: bug? game did not float LNWR.
  [12:32]ramanraj: For end scoring, need to add 30 per share to LNWR total.

No message about float for LNWR (down and to the right) from sell out above. Only the prior round when the stock when up.

        [09:16]edhew passes
        [11:08]Threepumpchump passes
        [11:39]ramanraj passes
        [11:39]No bids on minor M11, it will close and a 5 train is removed
        [11:39]11 closes
        [11:39]SWR's share price changes from £300 to £330
        [11:39]NER's share price changes from £220 to £245
        [11:39]LNWR's share price changes from £200 to £220
        [11:39]GWR's share price changes from £120 to £135
        [11:39]CR's share price changes from £110 to £120
        [11:39]-- New player order: Threepumpchump (£1090), ramanraj (£42), edhew (£30)
        [11:39]-- Operating Round 8.1 (of 2) --

[KevinR1000]

LNWR thing is definitely not a bug.

LNWR floated exactly as specified in AAG's errata :

4.12.1: Last sentence should say “If the token is already at the top of the chart, it moves diagonally one space down and to the right.”

Market before the final pass:

Market after the final pass:

[benjaminxscott]

@ramanraj2 - to triage the bank breaking issue, it would be super helpful if you had an example game where this happened - could you link an example game from your game history?

(probably someone with DB access could pull it, I don't personally have DB access however)

[ramanraj2]

Hi...

Didn't know we had access to game history!

Game id 48737. Time stamp 16:35. Bank breaks on credit of 1300 from bid to minor 30 at end of share round.

Player dialog about it starts at 16:36.

Hope this helps!

Raman

Get Outlook for Androidhttps://aka.ms/ghei36

---

From: Benjamin Scott @.> Sent: Monday, July 12, 2021 9:45:44 AM To: tobymao/18xx @.> Cc: ramanraj2 @.>; Mention @.> Subject: Re: [tobymao/18xx] [ 1822] bidding on minor is able to break the bank (#5953)

@ramanraj2https://github.com/ramanraj2 - to triage the bank breaking issue, it would be super helpful if you had an example game where this happened for you, could you link from your game history?

(probably someone with DB access could pull it, I don't personally have DB access however)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/tobymao/18xx/issues/5953#issuecomment-878339603, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUYA5RCGA6WU36LPGZAX56DTXL5ZRANCNFSM475B3KOA.

[benjaminxscott]

ok I edited that repro into the original report