search

tobymao / 18xx

A platform for playing 18xx games online!
https://18xx.games
Other
285 stars 186 forks source link

[Auto] Auto actions don't drop at the start of SR1. #6324

Open Auzzy opened 3 years ago

Auzzy commented 3 years ago

Game link: https://18xx.games/game/55612?action=38

At the beginning of new rounds, auto actions normally disable. However, if you set auto-pass during the initial private auction, it does not disable at the beginning of SR1.

magnusrk-ch commented 2 years ago

Auto actions clear on round change, if the new round is the wrong kind. So if you have a stock round auto action it will clear if the round changes to operating, auction, or something else that's not stock.

In the game link above, the round was not stock, but you set a stock auto action anyway. Then the round changed to stock, which doesn't clear the action, and the auto pass started taking effect.

It doesn't seem to me that anything should be changed here. We could disallow setting auto actions for rounds that aren't currently active, but setting an auto action for an upcoming SR seems like a valid thing to do.

magnusrk-ch commented 2 years ago

I guess the question to ask is why you set an SR auto pass action if you didn't want an SR auto pass action?

Auzzy commented 2 years ago

In 18CO (and most games which have an auction), you may want to pass bidding unless someone outbids you. This is even more useful in 18CO, since its initial auction can be a bit long due to not ending until everyone passes in a row. So I set the auto pass action on the Auction Round. When it changed to a Stock Round, the pass that was set on the Auction Round didn't clear.

magnusrk-ch commented 2 years ago

Does that actually work? As the name says, "Auto Pass in Stock Round" is only intended for stock rounds. I don't see anything in the code that would make it work in the auction.