[18MEX] Restart Last Turn during auction restarts the whole waterfall

[mggarofalo]

Game ID: 63597 (link: https://18xx.games/game/63597)

During the auction, all privates except Mexico City-Acapulco Railroad had bidders. I purchased Mexico City-Acapulco Railroad, which triggered the cascade of individual-private auctions. We completed all auctions and, after winning Mexican National Railroad, I set NdM's par. I decided I wanted to undo and continue bidding on Mexican International Railroad, so I clicked "Restart Last Turn", which reverted the game to, apparently, the previous action, which was my purchase of Mexico City-Acapulco Railroad.

I'm not sure that it matters, since I think this is server-side, but I'm on Chrome 96.0.4664.93 (Official Build) (64-bit) (cohort: Stable)

[perwestling]

@mggarofalo "Undo" reverts the previous action, which is setting the NdM's par. What "Restart Last Turn" is is not as clear to me.

What would you expect to revert to when doing "Restart Last Turn"? What is a Turn in this context?

As you can click Undo twice, to get back to the MIR bidding I think you can get there you want to be.

So maybe this is Good enough? I am suggesting that this issue can be closed. OK?

[mggarofalo]

@perwestling I was slightly unclear. When I said "action", I meant the last action before the waterfall auction.

To give more detail with links: At this point (https://18xx.games/game/63597?action=66), I clicked Restart Last Turn. I expected the game to revert by one action, functionally identical to Undo, because I had only completed one action on my turn. Action 65 asked me to set NdM's par price. Action 64 asked user munkishine to bid or pass on MIR. So, to my mind, "This Turn" encompassed actions 65 and 66.

What actually happened was that the game reverted to action 12 (https://18xx.games/game/63597?action=12). There's no context in which I'd expect "Last Turn" to mean "the last turn before the waterfall of private auctions kicked off".

The bug is that "Turn" has a different meaning in 18MEX within the game space of the waterfall auction and there's no UI indication of this fact.

[perwestling]

@mggarofalo I did check the game and thought what happend in the game and thought it reasonable. The turn in this case is the complete orders of a player during the main auction, and the triggered auctions are subturns.

But it might be confusing. So maybe it should be turned off? Maybe general for all auctions, or 18MEX specifically. I will check this out.

[perwestling]

I believe this to be a general issue, that exists for all games with waterfall auctions during ISR. I have therefor added 1830 label is this is the grandfather of all ISR waterfall auction games.

I will remove my assign to show that I am not working to solve the general issue.

[perwestling]