Color match stock market to yellow/orange/brown zone indicators

[ChrisTheCat]

The stock market yellow and orange are clearly yellow and orange. The charter yellow looks more like a yellowish chartreuse and the orange looks more like brown. It would be better if the colors were a closer match. In the screenshot below, it isn't hard to see that UR's orange is different than TR's yellow, but when only one of the colors is displayed on the charter (if the UR wasn't in the zone, for example), the colors are ambiguous.

[jenf]

Technically they're the same color, but they are slightly transparent as done with the spreadsheet.

[ChrisTheCat]

Why are they slightly transparent? Is there a reason for doing that, since it makes the colors harder to distinguish/understand?

On Wed, Jul 1, 2020 at 6:45 AM Jennifer Freeman notifications@github.com wrote:

Technically they're the same color, but they are slightly transparent as done with the spreadsheet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/942#issuecomment-652427804, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCT6EYYXXIDCTOZLYKTK3LRZM4YJANCNFSM4OMS4PXQ .

[jenf]

It was copied and paste to keep the same format as the spreadsheet.

The biggest question is should it be 0.4 or should it be fully opaque. How does that interact with dark mode.

[ChrisTheCat]

I'd argue the spreadsheet colors also need to be changed to look more like the colors on the stock market.

Or, perhaps the entire stock market should use transparency and have a dark mode option (no white spaces, only black...) but that might cause problems with distinguishing the tokens.

If the purpose of the color is to say "your stock is in this color on the market" then they should render as the same color on the screen.

On Wed, Jul 1, 2020 at 6:56 AM Jennifer Freeman notifications@github.com wrote:

It was copied and paste to keep the same format as the spreadsheet.

The biggest question is should it be 0.4 or should it be fully opaque. How does that interact with dark mode.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/942#issuecomment-652433545, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCT6E5CFFXYJKYIHRJ24KDRZM567ANCNFSM4OMS4PXQ .

[scottredracecar]

Assuming the most prominent background colors are white and black, any amount of transparency will make the highlights display differently than the stock chart--which to my eye appears to possibly have 100% opacity.

So probably the baseline should be to use 100% opacity for these colors everywhere.

On Wed, Jul 1, 2020 at 8:56 AM Jennifer Freeman notifications@github.com wrote:

It was copied and paste to keep the same format as the spreadsheet.

The biggest question is should it be 0.4 or should it be fully opaque. How does that interact with dark mode.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/942#issuecomment-652433545, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6CEXFDZ35ICNTJNJQZ4STRZM57BANCNFSM4OMS4PXQ .

[yzemaze]

The biggest question is should it be 0.4 or should it be fully opaque. How does that interact with dark mode.

1.0 might be too harsh on dark bgs, but 0.8 or 0.9 should work well. You’d have to explicitely set (font) color of the market row to black or maybe color_for(:font2) [== alternative font color, which is used on stockmarket, too] to work along nicely with user defined colors (aka "dark mode").

[ryanespin]

So with a background at 0.8 opacity, it looks like this:

Maybe consider doing just the font color the yellow/orange?

[yzemaze]

Colored font doesn’t work on light bg (yellow on white!)

[ryanespin]

Colored font doesn’t work on light bg (yellow on white!)

Yup sorry, I meant specifically for dark mode only on the font color.