tobymao / 18xx

A platform for playing 18xx games online!
https://18xx.games
Other
278 stars 180 forks source link

[1841] Stock Round auto-action not being ignored during an Operating Round #9522

Closed summerjumbo closed 11 months ago

summerjumbo commented 11 months ago
On a 1841 game: https://18xx.games/game/133385 a player could not proceed the sequence of operating round of SFTC. They could not went beyond the skip trains. **What's your Game ID?** 15422

How to Reproduce the Bug? go that page and click Skip(trains)

Which Browser / Platform? Opera one101.0.4843.43 and Microsoft Edge 116.0.1938.62

roseundy commented 11 months ago

Looks like an infinite loop.

Unfortunately, I'm leaving town in a few minutes. I'll be back on Sunday and diagnose it then.

mahonyb commented 11 months ago

The page freezes. No user interaction and no page updates with panning. Most other buttons seem to work, it comes back with a refresh to the pre-freeze state. Just can’t proceed to next game started.

roseundy commented 11 months ago

I've root-caused this to a programmed auto-action to pass in a stock round erroneously being applied to a corporate financial operation during an operating round.

mahonyb commented 11 months ago

Initially, the problem persisted, not sure if that was what you expected.

I switched off auto and now we are on our way again.

Thanks for all your efforts, so cool to be able to revisit this classic after so many years.

On 4 Sep 2023, at 11:51 am, Steve @.***> wrote:

I've root-caused this to a programmed auto-action to pass in a stock round erroneously being applied to a corporate financial operation during an operating round.

— Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/9522#issuecomment-1704522184, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGIM7CV3XUZD32MRCIIKFLDXYU3K7ANCNFSM6AAAAAA4HLNUFQ. You are receiving this because you commented.

roseundy commented 11 months ago

I still need to deploy the fix. Glad you were able to make progress.

summerjumbo commented 11 months ago

Thanks for fixing!