search

tobymao / 18xx

A platform for playing 18xx games online!
https://18xx.games
Other
278 stars 180 forks source link

1841. Child Corp can’t EMR. #9614

Closed fsaglio closed 11 months ago

fsaglio commented 11 months ago

https://18xx.games/game/134283

AFI needs to EMR a train, and its parent corporation, SFTC needs to contribute funds.

The only shares that SFTC owns are shares of AFI.

If AFI tries to buy a train, we get an error that SFTC needs to sell a share.

If we try to have SFTC sell its share of AFI, we get an error that the share can’t be sold.

What's your Game ID?

How to Reproduce the Bug?

Which Browser / Platform?

roseundy commented 11 months ago

Yep, looks like a bug. SFTC should be able to sell one share of AFI.

roseundy commented 11 months ago

found the bug in emr_can_sell?

fsaglio commented 11 months ago

Should this be fixed? We are still stuck in the same spot.

On Fri, Sep 15, 2023 at 6:57 PM Steve @.***> wrote:

Closed #9614 https://github.com/tobymao/18xx/issues/9614 as completed via #9616 https://github.com/tobymao/18xx/pull/9616.

— Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/9614#event-10388059269, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQUCM4IXEU2NTQMPI2QX4RDX2TMODANCNFSM6AAAAAA4ZE4NYA . You are receiving this because you authored the thread.Message ID: @.***>

roseundy commented 11 months ago

While it is fixed in our code base, it hasn't been deployed to the website. I'll deploy it this morning.

roseundy commented 11 months ago

The fix is now live on 18xx.games