search

tobymao / 18xx

A platform for playing 18xx games online!
https://18xx.games
Other
279 stars 182 forks source link

[1847AE] Tile upgrades not functioning correctly, and missing for green cities #9852

Closed HerbyMcGee closed 8 months ago

HerbyMcGee commented 10 months ago

What's your Game ID? https://18xx.games/game/138153?action=837#tiles

How to Reproduce the Bug? image

  1. Tile upgrade options hide behind the manifest in upper row of manifest
  2. Tile upgrades are not shown for Green City tiles

image

Which Browser / Platform? Edge - Version 118.0.2088.76 (Official build) (64-bit) Windows 11

Galatolol commented 10 months ago

From what I see this is how it is displayed on the site. The issue is not 1847AE - specific - I suggest creating a new issue, dedicated only to that.

e.g. 1830: image

Tiles no 205 through 208 indeed should show their upgrades. I'll ask around to see if someone knows what may be the reason.

slapphappyjazz commented 10 months ago

This seems related to https://github.com/tobymao/18xx/issues/9280 - "Layers out of order in Tiles tab when viewing upgrades"

benjaminxscott commented 10 months ago

It seems like issue (1) may he addressed by https://github.com/tobymao/18xx/pull/9864

Issue (2) seems specific to this title, we may have to explicitly create upgrade paths for those tiles since they appear to be custom handled in code

Galatolol commented 10 months ago

It looks now like both issues are resolved.

https://18xx.games/game/138153?action=837#tiles