search

tobymao / 18xx

A platform for playing 18xx games online!
https://18xx.games
Other
279 stars 182 forks source link

[18SJ] undefined method player? in "Select A.W. Edelswärd's next corporation" step #9895

Closed HelenCheale closed 6 months ago

HelenCheale commented 10 months ago

Id:140833

Game not loading

How to Reproduce the Bug?

Which Browser / Platform?

benjaminxscott commented 10 months ago

last working action https://18xx.games/game/140833?action=37

https://gist.github.com/benjaminxscott/1a05df6255c96f2e6135cb7f18ed438c

"undefined method `player?' for #<Engine::Game::G18SJ::Game::WithNameAdapter:0x346e @host=<Engine::Player - A.W. Edelswärd> @receivership=<Engine::Player - NuttyH>>"

Looks like issue is in the step Select A.W. Edelswärd's next corporation It seems to throw an error after the corp is chosen and AWE is given 100% of its shares, so likely in the logic after that is handled

HelenCheale commented 10 months ago

Hi any idea if or when this issue will be fixed?

On Mon, 13 Nov 2023 at 17:43, Benjamin Scott @.***> wrote:

last working action https://18xx.games/game/140833?action=37

"undefined method `player?' for

<Engine::Game::G18SJ::Game::WithNameAdapter:0x346e @host

https://github.com/host=<Engine::Player - A.W. Edelswärd> @receivership=<Engine::Player - NuttyH>>"

— Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/9895#issuecomment-1808664502, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUSSDY3HJ3SDQHVYS6BYMADYEJL4LAVCNFSM6AAAAAA7JEPMCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBYGY3DINJQGI . You are receiving this because you authored the thread.Message ID: @.***>

HelenCheale commented 9 months ago

Hello do you have any idea if or when this issue will be fixed please?

On Fri, 17 Nov 2023 at 12:58, Helen Cheale @.***> wrote:

Hi any idea if or when this issue will be fixed?

On Mon, 13 Nov 2023 at 17:43, Benjamin Scott @.***> wrote:

last working action https://18xx.games/game/140833?action=37

"undefined method `player?' for

<Engine::Game::G18SJ::Game::WithNameAdapter:0x346e @host

https://github.com/host=<Engine::Player - A.W. Edelswärd> @receivership=<Engine::Player - NuttyH>>"

— Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/9895#issuecomment-1808664502, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUSSDY3HJ3SDQHVYS6BYMADYEJL4LAVCNFSM6AAAAAA7JEPMCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBYGY3DINJQGI . You are receiving this because you authored the thread.Message ID: @.***>

HelenCheale commented 9 months ago

Hi again do you have any idea whether this game is fixable or not, if you could respond please that would be great.

On Mon, 20 Nov 2023 at 18:25, Helen Cheale @.***> wrote:

Hello do you have any idea if or when this issue will be fixed please?

On Fri, 17 Nov 2023 at 12:58, Helen Cheale @.***> wrote:

Hi any idea if or when this issue will be fixed?

On Mon, 13 Nov 2023 at 17:43, Benjamin Scott @.***> wrote:

last working action https://18xx.games/game/140833?action=37

"undefined method `player?' for

<Engine::Game::G18SJ::Game::WithNameAdapter:0x346e @host

https://github.com/host=<Engine::Player - A.W. Edelswärd> @receivership=<Engine::Player - NuttyH>>"

— Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/9895#issuecomment-1808664502, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUSSDY3HJ3SDQHVYS6BYMADYEJL4LAVCNFSM6AAAAAA7JEPMCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBYGY3DINJQGI . You are receiving this because you authored the thread.Message ID: @.***>

benjaminxscott commented 9 months ago

I added / updated the issue title to make it easier for someone to fix it, I haven't personally played or understand 18SJ rules to fix it

dfannius commented 7 months ago

I have been informed that game 140833 has been deleted per the request in #10067.

HelenCheale commented 7 months ago

Thank you so much for dealing with this issue.

On Fri, 19 Jan 2024 at 20:27, Dan Schmidt @.***> wrote:

I have been informed that game 140833 has been deleted per the request in

10067 https://github.com/tobymao/18xx/issues/10067.

— Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/9895#issuecomment-1901066143, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUSSDY46XMCSVTJJFG65MPLYPLJKNAVCNFSM6AAAAAA7JEPMCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBRGA3DMMJUGM . You are receiving this because you authored the thread.Message ID: @.***>

perwestling commented 7 months ago

I am assigning myself to this, as a candidate for my backlog. Have not been doing any work for almost a year so no promises. If someone else want to have a look, please go ahead.

HelenCheale commented 7 months ago

Hi thank you very much for the offer but the game has now been deleted.

Many thanks.

On Mon, 22 Jan 2024 at 20:29, Per Westling @.***> wrote:

I am assigning myself to this, as a candidate for my backlog. Have not been doing any work for almost a year so no promises. If someone else want to have a look, please go ahead.

— Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/9895#issuecomment-1904753161, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUSSDYYWUZ3WRILK7G5PH5LYP3DZVAVCNFSM6AAAAAA7JEPMCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUG42TGMJWGE . You are receiving this because you authored the thread.Message ID: @.***>

perwestling commented 7 months ago

Yes, but I want to see if I can fix the issue to avoid it appearing again.

HelenCheale commented 7 months ago

Ok well thank you very much and I wish you lots of luck.

On Mon, 22 Jan 2024, 22:21 Per Westling, @.***> wrote:

Yes, but I want to see if I can fix the issue to avoid it appearing again.

— Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/9895#issuecomment-1904928408, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUSSDY47LLKBB4V74E2KRHTYP3Q6DAVCNFSM6AAAAAA7JEPMCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUHEZDQNBQHA . You are receiving this because you authored the thread.Message ID: @.***>

perwestling commented 6 months ago

@HelenCheale Thanks for trying out 18SJ 2 player variant. I hope you do try it again, now that this issue is fixed.

The game has been deleted, and the gist above did not work, so I used the info there to recreate this issue. The bug did appear in the end of SR and to me seems to always happen.

So I made a correction, and now this bug do not occur, but instead I managed to play several SRs without any issues.

Have now submitted a correction, which will make it 18SJ 2 player variant playable again, when the correction is deployed.

HelenCheale commented 6 months ago

Hi ok we will definitely try it again. Thank you all so much for all the hard work in getting these games fixed when they go wrong.

Many thanks

Helen

On Sun, 18 Feb 2024 at 13:48, Per Westling @.***> wrote:

@HelenCheale https://github.com/HelenCheale Thanks for trying out 18SJ 2 player variant. I hope you do try it again, now that this issue is fixed.

The game has been deleted, and the gist above did not work, so I used the info there to recreate this issue. The bug did appear in the end of SR and to me seems to always happen.

So I made a correction, and now this bug do not occur, but instead I managed to play several SRs without any issues.

Have now submitted a correction, which will make it 18SJ 2 player variant playable again, when the correction is deployed.

— Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/9895#issuecomment-1951331356, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUSSDYZXKCD35QIC6WZ4Y6LYUIBDJAVCNFSM6AAAAAA7JEPMCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGMZTCMZVGY . You are receiving this because you were mentioned.Message ID: @.***>