search

tobymao / saq

Simple Async Queues
https://saq-py.readthedocs.io/en/latest/
MIT License
532 stars 37 forks source link

use redis.aclose instead of close #102

Closed tiejunhu closed 9 months ago

tiejunhu commented 9 months ago

redis.close is deprecated since version 5.0.0

barakalon commented 9 months ago

saq supports redis>=4.2,<6.0 redis 4.2 doesn't have aclose: https://github.com/redis/redis-py/blob/v4.2.0/redis/asyncio/client.py So we'd have to drop support for some redis versions. I'm not sure that's worth it?

tobymao commented 9 months ago

can you adjust this pr to check if aclose exists?

tobymao commented 9 months ago

closing for now, happy to receive a pr with redis 4 compatibility

tiejunhu commented 9 months ago

ok. if redis 4 should be supported. let's keep the 'close' until it breaks on newer redis library.