search

tobymao / saq

Simple Async Queues
https://saq-py.readthedocs.io/en/latest/
MIT License
577 stars 39 forks source link

Unpin redis requirement #68

Closed sondrelg closed 1 year ago

sondrelg commented 1 year ago

Relates to #67

Note: I haven't deeply looked into the original reason for why it was pinned; just saw it had been resolved a while back.

sondrelg commented 1 year ago

Looks like there are other things preventing us from using saq on a Redis cluster. Saw a lot of 

redis.exceptions.RedisClusterException: transaction is deprecated in cluster mode

and 

redis.exceptions.RedisClusterException: EVALSHA - all keys must map to the same key slot

but I suppose the redis dependency might still be possible to unpin :relaxed:

tobymao commented 1 year ago

can you make it > 4.5.4 or whatever version jr was fixed so keep the condition but also add this

tobymao commented 1 year ago

i'll fix it on my end

sondrelg commented 1 year ago

Why not make it <5?

sondrelg commented 1 year ago

Ah cool, that's what you ended up doing. Sweet :relaxed:

tobymao commented 1 year ago

we’ll you can use 4.5.4 either…