tobymao / saq

Simple Async Queues
https://saq-py.readthedocs.io/en/latest/
MIT License
532 stars 37 forks source link

Added package saq.web to build #84

Closed grigi closed 1 year ago

grigi commented 1 year ago

Hi, thanks for releasing a new version, but it seems that the saq.web pacakges are not included. (my bad, I didn't verify that setup.py didn't use find_packages())

I also updated the CHANGELOG assuming the next release should be called v0.11.2

tobymao commented 1 year ago

the changelog should not be manual, i will never update it, you need to add an automatic changelog tool like semantic commits or something

grigi commented 1 year ago

the changelog should not be manual, i will never update it, you need to add an automatic changelog tool like semantic commits or something

Noted, I'll look for something that can automate it or get rid of it.

Otherwise I noticed another packaging mistake :sob:

RuntimeError: Directory '/home/grigi/work/magneto/.pyenv/lib/python3.11/site-packages/saq/web/static' does not exist

I'm making dinner now and dealing with the kids, so I'll only get to it tomorrow morning. Sorry

tobymao commented 1 year ago

219e702

can you check if this does it when you have time?

tobymao commented 1 year ago

https://github.com/tobymao/saq/commit/7e6e7739707a373ca8fff1ebed311849189b5ddf

grigi commented 1 year ago

7e6e773

Yay! It's working perfectly now! Thank you sir :bow: