search

tobyspark / folk-rnn-webapp

A community application for the folk-rnn folk music style modelling project
MIT License
3 stars 5 forks source link

Added some questions and answers to the front page of the folkrnn app #102

Closed boblsturm closed 5 years ago

boblsturm commented 5 years ago

"Repeats unrolled" is fine. :)

tobyspark commented 5 years ago

If you add that as a commit, I'll merge the pull request.

boblsturm commented 5 years ago

I think I added, then committed, then pushed, and now I requested a pull.

tobyspark commented 5 years ago

You did everything perfectly to create the pull request. We're now improving it. So tweak the text to include 'unrolled', commit, push and this pull request will update itself. And then I hit the 'merge' button.

All a bit of a faff over a single bit of prose, but hopefully you can see the value for chunkier (and potentially more dangerous) changes, so it's a good rehearsal =]

tobyspark commented 5 years ago

Closed? I haven't merged it, waiting for the 'unrolled' commit.

boblsturm commented 5 years ago

I closed it because I made another change... but now I see that wasn't the way to do it.

boblsturm commented 5 years ago

I made another pull request though.

tobyspark commented 5 years ago

I don't see another pull request. If you just commit, push, it should appear here. But, having said that, if you have committed and it doesn't appear here... I'm not sure.

boblsturm commented 5 years ago

I just pushed.

boblsturm commented 5 years ago

How about now?