search

tobyspark / folk-rnn-webapp

A community application for the folk-rnn folk music style modelling project
MIT License
3 stars 5 forks source link

TMFS: markdown in comments? #110

Closed boblsturm closed 5 years ago

boblsturm commented 5 years ago

Trying to make a link on my comment here: https://themachinefolksession.org/tune-of-the-month/1

Is there a reason to not allow links here?

tobyspark commented 5 years ago

I might have been trying to keep things simple or stop spam links... but, yeah, no solid reason. I will make it render these as markdown.

tobyspark commented 5 years ago

Instead of markdown, which requires you to format links in a specific way, I've filtered the plain text through urlize, which just turns URLs into clickable links. Should be what most people expect, and will keep the formatting of comments minimal.

So, description fields when you contribute a tune, recording, tune of the month etc. are markdown, but everything else should just urlize.

tobyspark commented 5 years ago

Fixed in #118