search

tobyspark / folk-rnn-webapp

A community application for the folk-rnn folk music style modelling project
MIT License
3 stars 5 forks source link

TMFS: Setting title disappears #112

Closed boblsturm closed 6 years ago

boblsturm commented 6 years ago

When I add a setting and change the title in the title field, that title disappears. It seems only adding the title explicitly to the ABC has that intended effect.

tobyspark commented 6 years ago

The basic mechanism here is that the title field live-updates the T: field in the abc, and on submission the title is saved from what's found in the abc.

I could update this to make it bi-directional. And possibly the regex isn't quite what it needs to be as the live-update seems to stop once they're out of sync.

tobyspark commented 6 years ago

And possibly the regex isn't quite what it needs to be as the live-update seems to stop once they're out of sync.

This was caused by a subtle use of HTML bug, and is now fixed in a1a8cc61b25666f8434810a5bac914879123e59c

I could update this to make it bi-directional

Implemented in 07104e25dae29a534827fc577f0d75f81d9b6f87