search

tobyspark / folk-rnn-webapp

A community application for the folk-rnn folk music style modelling project
MIT License
3 stars 5 forks source link

TMFS: Can't change tune #123

Closed boblsturm closed 5 years ago

boblsturm commented 5 years ago

I am just trying to add "L:1/8" but get "This tune is not a variation of another." Same thing happens on tune 317. But I was able to change the others.

screen shot 2018-10-04 at 10 33 46 am

tobyspark commented 5 years ago

That means the body of the ABC (i.e. not headers) is the same as another tune's body. So the exact same RNN parameter'd tune was archived twice?

Regardless, I thought the intent was to keep folk-rnn tunes exactly as generated, and then all further human tweaking should be done as a setting?

boblsturm commented 5 years ago

It would be but L:1/8 is necessary to make it display right. I'm not sure if the same tune was archived twice.

tobyspark commented 5 years ago

The tune you're trying to edit – http://themachinefolksession.org.local:8000/tune/320

Has the same body as the next tune – http://themachinefolksession.org.local:8000/tune/321

They are both generated by folk-rnn with the same parameters, but are different folkrnn generations.

So there is potentially a problem here, but it isn't the inability to add the "L:" term. somewhere between folkrnn.org and machinefolk.org we should be detecting idential folkrnn submissions?

boblsturm commented 5 years ago

Got it. I deleted #320

On Fri, Oct 26, 2018 at 11:28 AM Toby Harris notifications@github.com wrote:

The tune you're trying to edit – http://themachinefolksession.org.local:8000/tune/320

Has the same body as the next tune – http://themachinefolksession.org.local:8000/tune/321

They are both generated by folk-rnn with the same parameters, but are different folkrnn generations.

So there is potentially a problem here, but it isn't the inability to add the "L:" term. somewhere between folkrnn.org and machinefolk.org we should be detecting idential folkrnn submissions?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tobyspark/folk-rnn-webapp/issues/123#issuecomment-433347127, or mute the thread https://github.com/notifications/unsubscribe-auth/AJy6ZOe-fAsUTT86hq67MGBACBSX9mceks5uotXYgaJpZM4XHnmc .

-- Bob L. Sturm, Associate Professor Speech, Music and Hearing School of Electronic Engineering and Computer Science Royal Institute of Technology KTH, Sweden https://highnoongmt.wordpress.com