search

tobytwigger / laravel-job-status

The only Laravel job debugging tool you'll ever need
https://tobytwigger.github.io/laravel-job-status
MIT License
19 stars 2 forks source link

[Documentation] incorrect suggested value for `track_anonymous` ? #51

Closed shutupflanders closed 1 year ago

shutupflanders commented 1 year ago

After installing this package and publishing the configuration, I was just reading through the docs and noticed a potentially incorrect suggestion for track_anonymous:

https://tobytwigger.github.io/laravel-job-status/enable-tracking/

image

Should this be true? as per the configuration docblock: By default, we will only track jobs that run that use the 'Trackable' trait. If this is set to true, we will track information about any job with no configuration needed.

Thanks for putting this together, I'm eager to get it running!

shutupflanders commented 1 year ago

Best to put a note about using true by the way, I use Laravel Scout in a project with this and it was unable to track the MakeSearchable Job, it threw an uncatchable error, if memory serves it was looking for $jobName or something. You aren't able to easily modify the 3rd party jobs, so perhaps a warning in the documentation is needed.

tobytwigger commented 1 year ago

Hey @shutupflanders - nice spot! Have just fixed this in #59 .

Thanks again for your contributions and feedback on the documentation - I'm looking forward to getting it running properly too!

Hopefully we can edit this package to properly handle any errors from third party jobs, but for now I've added a warning as suggested.