tobyweston / temperature-machine

Data logger for multiple DS18B20 temperature sensors on one or more machines
Apache License 2.0
67 stars 22 forks source link

Fahrenheit temperature please :) #60

Open matty256 opened 6 years ago

matty256 commented 6 years ago

Sorry Celsius, I'm a Fahrenheit guy. I'd love the ability to render temperatures in Fahrenheit on the website. Thanks!

tobyweston commented 6 years ago

I'm surprised this hasn't been asked for more! I'll see what I can do 😄

bpthomas commented 6 years ago

looking forward to Fahrenheit as well, thanks!

mboroff commented 5 years ago

No year on this request. Was it 2018? When might milestone 2.2 be released.

tobyweston commented 5 years ago

No firm plans yet as this is OSS and I work on it in my free time. It’s OSS so PRs welcome!

mboroff commented 5 years ago

Ok Toby.

It works great as is. I can always google the conversion or ssh into my Pi and run my test script.

I was a programmer for 40 years. Which file retrieves the temperature? I’d like to take a look.

Marty

Sent from my iPhone

On Dec 23, 2018, at 2:51 AM, Toby notifications@github.com wrote:

No firm plans yet as this is OSS and I work on it in my free time. It’s OSS so PRs welcome!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

tobyweston commented 4 years ago

Just thinking... do you think it would work to have temperatures recorded either as F or C permanently (i.e. not be able to switch between the two)? It may be harder to support switching unless I duplicate the storage (RRD), on for C and one for F... 🤔

mboroff commented 4 years ago

How about a setting that says display F or C and always store C. Do the calculation for F when you get the value. Most probes retrieve C.

Cron runs a program to send an email with the temp and I convert at format time. You can use the same variable if you like.

Marty

Sent from my iPhone

On Oct 31, 2019, at 3:52 AM, Toby notifications@github.com wrote:

 Just thinking... do you think it would work to have temperatures recorded either as F or C permanently (i.e. not be able to switch between the two)? It may be harder to support switching unless I duplicate the storage (RRD), on for C and one for F... 🤔

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

DemBones78 commented 4 years ago

I don't see the need to be able to switch back and forth. The people that want / need F (my self included) the main thing is just getting this ability sooner the better. If all the data was stored in F and I really needed a C value i would just convert it my self

tobyweston commented 4 years ago

I'll have a look at your suggestion @mboroff. The trouble I have is the JavaScript chart as I'll have to convert all C values for 24 hours and then send it over to be rendered by the charting library. I'll give it a go. Similarly, I'll aim to convert the live temperature reading on the fly...

mboroff commented 4 years ago

Toby

Below is an example of the email I get. The code is python.

Marty

Sent from my iPhone

Begin forwarded message:

From: martin.boroff@gmail.com Date: October 31, 2019 at 9:00:03 AM CDT To: martin.boroff@gmail.com Subject: Living Room Temperature

temperature = 71.7116 F 22.062 C

.

jmcjclark commented 4 years ago

After 2 years, is it likely that Fahrenheit will ever be added?

tobyweston commented 4 years ago

Yep. Dunno when.

Feel free to submit a pull request

DemBones78 commented 4 years ago

That pretty much applys to any features. ( Don't know when=never) This thing still average is all the temperature readings by default, a function universally hated that no one would ever want except Toby.

On Sun, Mar 1, 2020, 12:28 PM Toby notifications@github.com wrote:

Yep. Dunno when.

Feel free to submit a pull request

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tobyweston/temperature-machine/issues/60?email_source=notifications&email_token=ALFB6DGOMHUMKA2CGFSD6WDRFKSNXA5CNFSM4ESFGWKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENNGZCY#issuecomment-593128587, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALFB6DE67XKJOSQYRAJCAZTRFKSNXANCNFSM4ESFGWKA .

tobyweston commented 4 years ago

"Don't know when" means... I don't know when, not never. I do this on my own time amidst a busy life like the rest of us. Development comes in phases, I'll find time for a few months then get caught up elsewhere.

I'm interested in having other people use this and have made it freely available and develop it "in the open" to do just that. I have put thousands of hours into this project and am committed to making it better over time. I have implemented a bunch of features that I myself don't find useful, so I don't think it's very fair to say one toggle-able feature is "universally hated".

As with all OSS, I'm very happy for people to contribute code, but to date, I've had very few offers. If you don't like it, you're free to find other, better software out there or better still, contribute some code for features you do want.