tobyweston
commented
7 years ago CRC is already checked when parsing the file. A failed CRC check should result in a -\/ which will end up as an error in the log.
class ParserTest extends Specification {
"Fails to extract temperature with failed CRC check" >> {
val output =
"""|72 01 4b 46 7f ff 0e 10 57 : crc=57 NO
|72 01 4b 46 7f ff 0e 10 57 t=23125
""".stripMargin
Parser.parse(output) must be_-\/.like {
case error: CrcFailure => ok
}
}
}case class RecordTemperature(host: Host, input: TemperatureReader, output: TemperatureWriter, error: PrintStream = System.err) extends Runnable {
def run(): Unit = {
input.read.fold(error.println, temperatures => {
output.write(Measurement(host, now(), temperatures)).leftMap(error.println)
})
}
}case class CrcFailure() extends Error("CRC failure, this could be caused by a physical interruption of signal due to shorts, a newly arriving 1-Wire device issuing a 'presence pulse' or gremlins.")
Quaxo76
I'm not sure why it started happening but I'm seeing extreme spikes in temperature data.
Potentially ignore volitile readings or check the CRC when reading (as suggested in the Arduino forum).