`Integer` is missing `minimum()`, `maximum()` and `multipleOf()`

tobyzerner / json-api-server

A JSON:API server implementation in PHP.

https://tobyzerner.github.io/json-api-server/

MIT License

63 stars 21 forks source link

`Integer` is missing `minimum()`, `maximum()` and `multipleOf()` #77

Closed bertramakers closed 1 year ago

bertramakers commented 1 year ago

Looking at the documentation for Number and Integer, I'd assume that Integer would also have the minimum(), maximum() and multipleOf() methods that Number does.

Easiest fix would probably be to copy them to Integer, but it would be a bit of duplicate code.

tobyzerner commented 1 year ago

Just make sure you're on the latest - this should've already been fixed in 11fafff. (Added some more unit tests just now c4115be14d0d9f610c24b4d688145cf56dbc196d)

bertramakers commented 1 year ago

I missed the recent release, that fixed it indeed 👍