search

tobyzerner / json-api-server

A JSON:API server implementation in PHP.
https://tobyzerner.github.io/json-api-server/
MIT License
63 stars 21 forks source link

Literal defaults #80

Closed bertramakers closed 10 months ago

bertramakers commented 11 months ago

Hi,

I propose to add a convenience method to directly set a literal default value on fields, instead of using a callback. The callback is nice for scenario's like setting dynamic values based on the Context, but in a lot of cases we just want to set a default "hardcoded" value.

I've added a second method called defaultLiteral() so the choice between using a callback or a literal value is more explicit and there is less chance of accidental errors/bugs in my opinion. And I kept the original default() method so as to not introduce breaking changes. But I'm also open to other solutions if you prefer another approach.

However, I will be traveling the next two weeks and won't have access to my workstation so any changes you'd like you'll either have to implement yourself or wait for a couple of weeks. I will have access to my email/github to exchange messages though.

Thanks for the consideration!

bertramakers commented 11 months ago

I'm not sure why the prettier job always fails for my PRs, I think because it's looking for the branch in the original repo (for some reason) while it exists in a fork.

tobyzerner commented 10 months ago

Nice idea, thanks for the PR! I would just go with the single default method being able to handle both callbacks and literals. Don't need to worry about breaking changes during alpha ;) Will make this change and get it merged soon. Enjoy your travels!

bertramakers commented 9 months ago

Thanks for getting this merged @tobyzerner !

Unrelated, but I also just discovered that you have also already provided support for the Atomic Operations extension including support for lid. That makes this library so insanely powerful, I love it!