search

tochoromero / aurelia-table

Simple functional data table for Aurelia
https://tochoromero.github.com/aurelia-table
MIT License
67 stars 25 forks source link

Updated to add webpack deployment process. #16

Closed evenflow58 closed 8 years ago

evenflow58 commented 8 years ago

Resolves #15

You might want to ignore the bundle.js and set up the webpack command on your build (it's just webpack).

tochoromero commented 8 years ago

Thank you very much for the pull request. I have never used webpack so I know very little of how it works, it seems you are just adding some configuration that is specific for web pack. I assume this will have no effect if you are using JSPM or Aurelia CLI, right?

evenflow58 commented 8 years ago

Not to my knowledge. I quickly moved away from JSPM because of scalability issues and Aurelia CLI does not seem production ready. I'm still learning webpack myself. It shouldn't affect any of that unless they are looking at bundle.js, which I doubt they are since you didn't have it in your repo before.

evenflow58 commented 8 years ago

Doing some more testing and I found that this fork does not actually fix the problem. Users can update the aurelia > build > resources portion of package.json to pull in the files but that is not ideal. If I have time I'll try and work on creating a webpack bundle for this.

tochoromero commented 8 years ago

Thank you very much I appreciate it

evenflow58 commented 8 years ago

Closing this pull request as @ds2co got it to work.