search

tochoromero / aurelia-table

Simple functional data table for Aurelia
https://tochoromero.github.com/aurelia-table
MIT License
67 stars 25 forks source link

Allow filtering of data when some keyed columns contain null #2

Closed PhilipRieck closed 8 years ago

PhilipRieck commented 8 years ago

If you have a collection where some of the objects have a property that resolves to null, and you set the filter-keys to contain that property, the doFilter method would stop with an error trying to call toString() on the null value.

tochoromero commented 8 years ago

Thank you for sending the pull request, I added a small note. Also, for some reason your build is adding one extra space in one of the pagination files, I guess you can omit those from the commit.

PhilipRieck commented 8 years ago

I reverted the whitespace change on the build (sorry!). Great catch on 0 values being ommited, I've fixed that as well. Great simple component by the way - love it.

tochoromero commented 8 years ago

I have merged your pull request. Thank you for the fix :)

I'm glad you like the table, this is my very first open source contribution, please don't hesitate to send any comments or suggestions.