Closed PhilipRieck closed 8 years ago
The changes are good. I like the way you are checking for numbers. The only thing I would ask you to change before merging is to pull out the isNumeric function to be a class level function, just to be consistent with my programming style. Thank you very much for your collaboration.
Good call - mixed styles are confusing. I've moved it to a class level function.
Make sure you check this one out before accepting.
The issues I was having with the sort was this:
"" == "a"
, or as a string "31 comes after 301".isNaN
was pretty loose with what was a number. For example, "$1 off!" was considered a number on one of the browsers I'm testing withSo what this does is alter the sort to:
Please let me know your thoughts.