search

tock / libtock-rs

Rust userland library for Tock
Apache License 2.0
168 stars 109 forks source link

readme: add MSRV #499

Closed bradjc closed 1 year ago

bradjc commented 1 year ago

This seems to be pretty standard with Rust crates. Given that we are 1.5 years from the release of 1.59, just documenting this is probably good enough without changes to the build infrastructure.

I don't actually know that we don't need a newer version, but #394 indicates we need 1.59.

Fixes #394.

jrvanwhy commented 1 year ago

This is going to get out of date quickly without tests.

We should change the setup and test-stable targets in Makefile to test with the MSRV instead, e.g. by using cargo +1.59.0 instead of cargo +stable. We also need comments telling us where all to update the MSRV.

We should also specify the MSRV in Cargo.toml. The Cargo docs say rust-version can be inherited from the workspace, so we should probably use that.

bradjc commented 1 year ago

I think I just tried to see if 1.59 works, and I just get errors about something with ufmt. This is outside my wheelhouse, everyone should just keep their rustc up to date.