search

tock / libtock-rs

Rust userland library for Tock
Apache License 2.0
163 stars 109 forks source link

Makefile: use /usr/bin/env bash in favor of /bin/bash #507

Closed lschuermann closed 1 year ago

lschuermann commented 1 year ago

Not all systems have a /bin/bash (e.g., NixOS). Using either /usr/bin/env to look for an appropriate shell binary in the PATH, or using /bin/sh directly is more reliable and portable.

Fixes #504.

jrvanwhy commented 1 year ago

using /bin/sh directly is more reliable and portable

Nope, because that's not always Bash, which is why this line exists in the first place.

lschuermann commented 1 year ago

using /bin/sh directly is more reliable and portable

Nope, because that's not always Bash, which is https://github.com/tock/libtock-rs/issues/502#issuecomment-1678007408.

Oh, yes, absolutely! That's only portable in the sense that you're getting some (hopefully) Bourne shell-compatible shell.