tock / tock-www

Tock OS website
5 stars 20 forks source link

hardware page is cut off #55

Open sknebel opened 3 years ago

sknebel commented 3 years ago

https://www.tockos.org/hardware/ shows the full Table of Contents, but the page content is cut off after the "imix" section, and the links to e.g. the stm32-discovery lead nowhere, despite clearly being in the source file: https://github.com/tock/tock-www/blob/master/_pages/hardware.md

bradjc commented 3 years ago

I can't reproduce this, can you add what browser you are using, or anything that might help track down what is causing it?

sknebel commented 3 years ago

Firefox, on second look it appears to be triggered by uBlock origin (which I have set to be fairly strict) being active. Didn't expect a text page like that to load content through JS, so didn't try that before.

sknebel commented 3 years ago

Ah. found it, its not actually JS loading.

There is a nesting problem with the page content, and the rest of the article below the <form> ends up getting nested under the <form> tag, and uBlock has a filter rule that blocks the mc_embed_signup class, which due to the nesting issue wipes out the entire lower half of the article. Very "fun" bug...

sknebel commented 3 years ago

specifically, looking at the source of https://www.tockos.org/hardware/ :

<div id="mc_embed_signup">
  <form action="https://tockos.us14.list-manage.com/subscribe/post?u=3ab7c13c2409f58a1553f170a&amp;id=e9dd44c1a1" method="post" id="mc-embedded-subscribe-form" name="mc-embedded-subscribe-form" class="validate" target="_blank" novalidate="">
    <div id="mc_embed_signup_scroll">
      <h3>Sign up for notifications on imix availability</h3>
      <div class="mc-field-group">
        <p><label for="mce-EMAIL">Email Address  <span class="asterisk">*</span>
</label>
<input type="email" value="" name="EMAIL" class="required email" id="mce-EMAIL"></p>
      </div>
      <div class="mc-field-group">
        <p><label for="mce-FNAME">First Name </label>
<input type="text" value="" name="FNAME" class="" id="mce-FNAME"></p>
      </div>
      <div class="mc-field-group">
        <p><label for="mce-LNAME">Last Name </label>
<input type="text" value="" name="LNAME" class="" id="mce-LNAME"></p>
      </div>
      <div id="mce-responses" class="clear">
        <div class="response" id="mce-error-response" style="display:none"></div>
        <div class="response" id="mce-success-response" style="display:none"></div>
      </div>
      <div style="position: absolute; left: -5000px;" aria-hidden="true">
        <p><input type="text" name="b_3ab7c13c2409f58a1553f170a_e9dd44c1a1" tabindex="-1" value="">&lt;/div&gt;</p>
        <div class="clear">
          <p><input type="submit" value="Subscribe" name="subscribe" id="mc-embedded-subscribe" class="button">&lt;/div&gt;</p>
        </div>
        <p>&lt;/form&gt;</p>
      </div>

the second to last line: that </form> clearly shouldn't have been escaped when turning the .md file into HTML.