search

tockn / MPU6050_tockn

Arduino library for easy communication with MPU6050
218 stars 84 forks source link

Remove extraneous `requestFrom(int, int, int)` calls #20

Closed neilbalch closed 5 years ago

neilbalch commented 5 years ago

The lines changed cause problems on the STM32 platform, where they cause an error due to the unavailability of the requestFrom(int, int, int) signature.

At any rate, the way this library uses the function call, the problem third parameter is extraneous, as the Arduino implementation of requestFrom(int, int) behaves exactly the same way as it would with requestFrom(int, int, int) with the third parameter being true.

tockn commented 5 years ago

Thanks! I'll check it weekend.

neilbalch commented 5 years ago

Any word on being able to merge this, @tockn ? I'd love to be able to use the master branch of this in my project.

tockn commented 5 years ago

LGTM!

neilbalch commented 5 years ago

Can you create a new "Version" for the PlatformIO registry?

neilbalch commented 5 years ago

PlatformIO doesn't seem to know that a 1.5.0 version exists.

tockn commented 5 years ago

@neilbalch complete. https://platformio.org/lib/show/2824/MPU6050_tockn