Settlement Sheet: adding a Mastery to settlement innovations does not apply the Specialization to all living survivors

[toconnell]

...and it should. Basically, it should work just like adding the Mastery to an individual Survivor.

Additional detail from error report:

So, months ago one survivor got axe mastery. I clicked the master check box on her sheet and it loaded fine for that individual survivor.

Then, I clicked Mastery - Axe Innovation and it loaded and now shows up on each living survivor in the settlement.

Today, I did the same procedure for katar and it loaded on the survivor sheet but then gave me a weird error and said it logged me out but didn't actually log me out.

Then I tried to add it to innovations and it adds it on the settlement sheet but not on every living survivor.

Sounds like the initial API call to add the A&I got rejected or failed or otherwise bombed out, which threw everything off.

[toconnell]

Additional:

So I tried other masteries (despite not having any actual survivors with the correct boxes checked) and they don't load either.

However, I created a "test" survivor to see if the specialization was automatically added to them while the Katar Mastery was innovated and that worked fine.

So it seems like this could be the coding issue:

1. Innovated masteries DO NOT automatically load into current survivors unless at least one has all 8 proficiency boxes checked

2. OR the coding is just not letting them carry over regardless of someone with all 8 checked (a master)

3. New survivors seem to be coded properly and are loading the specialization automatically

[toconnell]

Yeah...turns out that this is just totally broken. I'm removing the hooks from the survivor method and rewriting it under the settlement method.

[toconnell]

Things that were broken before and that now work correctly:

• [ ] weapon mastery is automatically applied to survivors when their proficiency number hits >= 8
• [ ] new/newborn survivors are created with the specializations for masteries in the settlement innovations list
• [ ] current/living survivors now get the specialization when any survivor gets the mastery
• [ ] current/living survivors now get the specialization when the mastery is added to settlement innovations
• [ ] removing the mastery innovation from the settlement innovations pulls the specialization from living survivors...
• [ ] ...but survivors who have enough points in WM and are specialists already DO NOT lose it.

I think we're good here.