API server: multiple query params cause crash-like output

todbot / Blink1Control2

Blink1Control GUI to control blink(1) USB RGB LED devices.

http://blink1.thingm.com/

Apache License 2.0

154 stars 24 forks source link

API server: multiple query params cause crash-like output #174

Closed todbot closed 2 years ago

todbot commented 2 years ago

As reported by user Mike (@p1ckzi) via email:

If the same parameter is given twice in the query args, like: http://localhost:8934/blink1/pattern/stop?pname=test&pname=test then the output will look like:

<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>Error</title>
</head>
<body>
<pre>TypeError: pattid.startsWith is not a function<br>
[additional response elided]

todbot commented 2 years ago

Also fixed in commit https://github.com/todbot/Blink1Control2/commit/5c4892c4a9f5698208029d88a1fdf5752043ee91 was disabling /blink1/input* API endpoints