search

todbot / Blink1Control2

Blink1Control GUI to control blink(1) USB RGB LED devices.
http://blink1.thingm.com/
Apache License 2.0
154 stars 26 forks source link

Bug: Copying a color pattern is not a deep copy #194

Open Waboodoo opened 1 year ago

Waboodoo commented 1 year ago

Steps to Reproduce

  1. Find any color pattern in the UI
  2. Click the Dropdown button on the right
  3. Select "Copy pattern"
  4. On the copy, click the Dropdown button again
  5. Select "Edit pattern"
  6. Select any of the pattern's colors and change it

Expected Result

Only the selected color in the pattern being edited is changed

Actual Result

The selected pattern is changed, but also the original pattern from which it was copied. Even when that pattern is locked.

It seems that the copy is only a shallow copy, still sharing some parts with its original pattern.

todbot commented 1 year ago

Yikes. Thank you for the detailed report. I'm looking into it now.