Build produces compiler warning on FreeBSD 11.2

duncan-bayne commented 5 years ago

When I build blink1-tool on FreeBSD (with https://github.com/todbot/blink1-tool/pull/14 merged), I get the following compiler warning:

hidapi/libusb/hid.c: In function 'get_usb_string':
hidapi/libusb/hid.c:353:18: warning: passing argument 2 of 'libiconv' from incompatible pointer type [-Wincompatible-pointer-types]
  res = iconv(ic, &inptr, &inbytes, &outptr, &outbytes);
                  ^
In file included from hidapi/libusb/hid.c:48:0:
/usr/local/include/iconv.h:85:15: note: expected 'char **' but argument is of type 'const char **'
 extern size_t iconv (iconv_t cd,  char* * inbuf, size_t *inbytesleft, char* * outbuf, size_t *outbytesleft);
               ^

todbot commented 5 years ago

Hi, This looks to be an issue with upstream hidapi. You should file the issue there.

duncan-bayne commented 5 years ago

@todbot I don't think there'd be much point.

https://github.com/signal11/hidapi/issues/373

todbot / blink1-tool

Build produces compiler warning on FreeBSD 11.2 #16