search

todbot / blink1-tool

Command-line tools and C library for blink(1) USB RGB LED
https://blink1.thingm.com/
Other
84 stars 15 forks source link

"--version" command reports "v0" when compiling from .zip download #2

Closed todbot closed 5 years ago

todbot commented 6 years ago

This is because the Makefile has:

GIT_TAG?="$(strip $(shell git tag 2>&1 | tail -1 | cut -f1 -d' '))"
# deal with case of no git or no git tags, check for presence of "v" (i.e. "v1.93")
ifneq ($(findstring v,$(GIT_TAG)), v)
  GIT_TAG:="v0"
endif

which fails in interesting and non-useful ways if you either don't have git or are building from the zip and not a checkout.

msoultan commented 6 years ago

If this was in response to me, I very well could have messed something up - I'm far from a programming/compiling expert so make sure you verify this to be true.

todbot commented 5 years ago

I think this is fixed.

todbot commented 5 years ago

oh no wait it is not.

todbot commented 5 years ago

okay now it is fixed.