todbot / blink1

Official software for blink(1) USB RGB LED by ThingM
https://blink1.thingm.com/
Other
958 stars 236 forks source link

Command line installation fails on OSX: illegal option -D #252

Closed c4live closed 9 years ago

c4live commented 9 years ago

This is the output of make install for the commandline subdirectory, on my machine:

$ make install
Building for OS=macosx BLINK1_VERSION=v1.98-macosx-x86_64 USBLIB_TYPE=HIDAPI
cc -dynamiclib -o libBlink1.dylib -Wl,-search_paths_first -framework IOKit -framework CoreFoundation -mmacosx-version-min=10.8 -DUSE_HIDAPI -arch i386 -arch x86_64 -O2 -D_THREAD_SAFE -MT MD -MP  -I./hidapi/hidapi  -std=gnu99  -g -DBLINK1_VERSION=\"""v1.98"-macosx-"x86_64""\" ./hidapi/mac/hid.o blink1-lib.o  -framework IOKit -framework CoreFoundation
install -D blink1-tool /usr/local/bin/blink1-tool
install: illegal option -- D
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 file2
       install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 ... fileN directory
       install -d [-v] [-g group] [-m mode] [-o owner] directory ...
make: *** [install] Error 64

Solution: remove the -D flag in the Makefile line that define the INSTALL program, from this:

INSTALL = install -D

to this:

INSTALL = install

and everything works like a charm!

todbot commented 9 years ago

Thanks, fixed! (in the repo)