search

todbot / blink1

Official software for blink(1) USB RGB LED by ThingM
https://blink1.thingm.com/
Other
954 stars 237 forks source link

Fixed "The device does not support the specified langid" error #295

Closed pedronavf closed 7 years ago

pedronavf commented 7 years ago

In the latest PyUSB, usb.util.get_string no longer has a length argument (commit dac78933f6a6eaf5ae82f48e2f4e7d1733dc2f98) therefore it gets index as langid instead of None and fails.

todbot commented 7 years ago

thanks!

jnth commented 7 years ago

Thank you for this fix. Could you release a new version on PyPi ? (relates to #219)

I think you can change (in python/pypi/setup.py) install_requires from pyusb>=1.0.0b1 to pyusb>=1.0.0 to use the last PyUSB release.

todbot commented 7 years ago

Hi @jnth, The version on PyPi is a fork of this repo, maintained by @salimfadhley.

pedronavf commented 7 years ago

@todbot, according to #219 you can push to PyPi, can't you? I'm working on a Home Assistant plugin and I need a working package in PyPi for people to use it.

salimfadhley commented 7 years ago

Make the fix to my repo and I can do a release.

On Thu, 26 Jan 2017, 08:38 Pedro Navarro, notifications@github.com wrote:

@todbot https://github.com/todbot, according to #219 https://github.com/todbot/blink1/issues/219 you can push to PyPi, can't you? I'm working on a Home Assistant plugin and I need a working package in PyPi for people to use it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/todbot/blink1/pull/295#issuecomment-275334091, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvzWfu0-bGEBjfB13KNJB8Op4rxVclwks5rWFt4gaJpZM4LlTNe .

todbot commented 7 years ago

Hey @salimfadhley, what if we made an entirely new github repo that's just for the blink1 Python package (you can own it if you want), but that we're both contributors on?

I initially made this repo not long after coming from SVN and hadn't yet embraced the "many small repo" philosophy. Now I quite like it and I'm finding myself frustrated having so much different functionality all in one big "blink1" repo.

salimfadhley commented 7 years ago

I probably shouldn't be the owner but I'd be happy to be a contributor. I've been meaning to contribute a few things. We still use Blink1s at Bank of America for all sorts of build-related notifications. Putting Python in it's own repo is a very good idea - it makes it so much easier for people who just want Python.

Speaking of this - probably the most valuable thing I can contribute is to set up the CI and get it building automatically. Let me know if that helps you.

Sal

pedronavf commented 7 years ago

Wouldn't it make sense, then, to have everything under the thingm github user? Right now the blink1 repo under thingm is a fork of todbot's repo, and I think people would search github for either blink1 or thingm, but not todbot. I think there's still value in having a big repo where everything related to blink1 is located, but maybe that can be achieved with submodules.

In any case, thingm (and/or todbot) should be able to push to PyPi so any changes are quickly made available to the world.

Pedro

On Thu, Jan 26, 2017 at 1:29 PM, Salim Fadhley notifications@github.com wrote:

I probably shouldn't be the owner but I'd be happy to be a contributor. I've been meaning to contribute a few things. We still use Blink1s at Bank of America for all sorts of build-related notifications. Putting Python in it's own repo is a very good idea - it makes it so much easier for people who just want Python.

Speaking of this - probably the most valuable thing I can contribute is to set up the CI and get it building automatically. Let me know if that helps you.

Sal

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/todbot/blink1/pull/295#issuecomment-275519512, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGUEOnOMIZYr8dtTQy1FANFMHtZk9rNks5rWRAogaJpZM4LlTNe .

todbot commented 7 years ago

Agreed, @pedronavf. It's on my todo list to move all thingm-related repos to the ThingM org.

todbot commented 7 years ago

Hi @salimfadhley,
Yes, I would very much like assistant in setting up the PyPi publishing and CI (I just got Travis & Appveyor sorta working for some other multi-OS projects I maintain and it's wonderful)

I set up the current todbot/blink1/python directory as a new repo (with all the history) here: https://github.com/todbot/blink1-python You've been added as a collaborator. I haven't added a LICENSE yet as I figure you should have the most say in that.