todbot / blink1

Official software for blink(1) USB RGB LED by ThingM
https://blink1.thingm.com/
Other
954 stars 237 forks source link

Blink1_pyusb.py only finds first attached device #297

Open fullphat opened 7 years ago

fullphat commented 7 years ago

I have two blink(1) devices connected but blink1_pyusb.py only finds one - is there a way to enumerate all attached devices and return a list of them? I'm limited to Python 2.7 so can't try the pypi variant of this library.

fullphat commented 7 years ago

Update: I've fixed blink1.py and blink1_pyusb.py to accept an optional "unit" argument on creation. At the moment this is just expected to be an int ranging from 0..n where 'n' is the total number of blink1 devices connected less one. It's a bit clunky, but it does work - for example:

blink1 = Blink1()
other_blink1 = Blink1(1)

blink1.fade_to_rgb( 1000,  255,255,255 )
other_blink1.fade_to_rgb( 1000,  255,255,255 )

Happy to share code - I don't really understand this git stuff :-)

todbot commented 7 years ago

Hi @fullphat, Thanks! We're trying to move the python library to its own repo. It's not fully fleshed out yet, but could you add this pull request to https://github.com/todbot/blink1-python?

fullphat commented 7 years ago

Will do - I'm very new to git so i'll read up on what needs doing with regards to pull requests! :)

I've forked the code, committed my changes and I've made a pull request - hopefully I've done it right!