search

toddams / RazorLight

Template engine based on Microsoft's Razor parsing engine for .NET Core
Apache License 2.0
1.51k stars 260 forks source link

Fixes #311 by taking the full namespace in the constructors that take… #312

Closed HakanL closed 4 years ago

HakanL commented 4 years ago

… an Assembly as the Assembly name isn't always the same as the namespace (it was the same in the unit tests that's why it worked there).

This change requires that projects that has the same namespace as the project name has to have the full namespace passed into the root namespace, I have updated the affected unit tests.

jzabroski commented 4 years ago

@HakanL I formatted the repository to follow the .editorconfig file. If you're using VSCode or Visual Studio 2017 or later, it should just pick up this config file and format correctly as you type unless you have some plug-ins that don't respect https://editorconfig.org/ conventions

HakanL commented 4 years ago

Should be good now, please confirm.

harmandeol commented 4 years ago

any plans to merge this ?

jzabroski commented 4 years ago

@HakanL Just published. Should show up in nuget.org within the hour. Thanks for your help. Finally catching up from COVID-19 disaster planning prep.

HakanL commented 4 years ago

Awesome, thank you!

harmandeol commented 4 years ago

thanks a lot